Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BLD: change file extension for installed static libraries back to .lib #23983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

rgommers
Copy link
Member

This fixes the test_cython failure mentioned in gh-23981.

@rgommers rgommers added 36 - Build Build related PR Meson Items related to the introduction of Meson as the new build system for NumPy component: numpy.random labels Jun 19, 2023
@rgommers
Copy link
Member Author

That worked, from a Windows wheel build log:

Linking static target numpy/random/npyrandom.lib

@mattip
Copy link
Member

mattip commented Jun 19, 2023

The two queued checks are not relevant for this PR, the others are passing.
Thanks @rgommers.

@mattip mattip merged commit 7190108 into numpy:main Jun 19, 2023
@rgommers rgommers deleted the fix-windows-npyrandom branch June 19, 2023 06:20
@rgommers rgommers added this to the 2.0.0 release milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR component: numpy.random Meson Items related to the introduction of Meson as the new build system for NumPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants