-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
CI: BLD: build wheels and fix test suite for Python 3.12 #23991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Python 3.12 has immortal refcounts; the initial and final values will be the same when accessing `sys.getrefcount` inside a test. Closes numpygh-23986
They require numpy.distutils, which isn't available on >=3.12 The `numpy.testing.extbuild` utility will need changing to make this work again. Could either use plain `setuptools` or `meson`.
Hmm, I tested on GitHub Actions on my own fork and that is happy with
The Cirrus CI yaml is a little different; I expected this to work but it doesn't:
it ends with:
not sure if it's not yet supported yet or the |
|
Is the cibuildwheel version current on that job? I see 2.12.1 where 2.13.1 is the latest. |
you mean to put a selector on the line in |
We need a recent `setuptools` to make `import distutils` work (that will then get the `setuptools`-patched version of it), and that is used in at least `numpy/core/tests/test_cython.py`.
Thanks @mattip, good catches. My brain is kinda fried it seems after the mini-sprint in the last 36 hours:) This is ready now. For merging it, please include |
The one CI failure is a connection issue; the actual job had completed and is green in Azure. |
Thanks @rgommers. Lets keep things moving. |
I merged with the github button and will manually kick off a wheel build |
Ah, guess I was wrong - thanks Matti! |
π I think manual button doesn't trigger the cirrus builds, but it probably doesn't matter much in practice, the next build is tomorrow anyway. |
No description provided.