Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: Add an orthogonally indexable attribute to ndarray #5749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jaimefrio
Copy link
Member

Needs plenty of discussion, and lots of tests to ensure correctness.

@shoyer
Copy link
Member

shoyer commented Apr 6, 2015

This looks really nice @jaimefrio! I did not realize doing orthogonal indexing without converting slices into ndarrays was possible.

For putting together a test suite, these tests I wrote for xray might be helpful:
https://github.com/xray/xray/blob/v0.4.1/xray/test/test_indexing.py#L28

@seberg
Copy link
Member

seberg commented Nov 30, 2015

Oh wow, I forgot about this one, so you actually had figured out all the reordering in python code, pretty nice (tends to be a bit mind boggling, eh ;))! Actually this could be useful for testing in principle, though probably better to just write extensive example tests.

To link it though, I think gh-6075 probably supercedes this.

@seberg
Copy link
Member

seberg commented Feb 1, 2016

Closing this in favour of my stuff for now (if you hate me for it, just reopen and tell me :)), though it is actually very nice, and maybe we should at least keep it in mind. Because of that, I will mention that I think the code does not handle boolean arrays as is ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants