Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve message IDs#1447

Draft
bocekm wants to merge 1 commit into
oamg:mainfrom
bocekm:improve-message-ids
Draft

Improve message IDs#1447
bocekm wants to merge 1 commit into
oamg:mainfrom
bocekm:improve-message-ids

Conversation

@bocekm
Copy link
Copy Markdown
Member

@bocekm bocekm commented Dec 6, 2024 •
edited
Loading

  • Make the message IDs unique (there are a few messages with the same ID).
  • Some IDs are misleading - don't correctly depict what the messages are about.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@bocekm
Improve message IDs
472262c 
Make the message IDs unique (there are a few messages with the same ID).
Some IDs are misleading - don't correctly depict what the messages are about.
@bocekm bocekm added kind/breaking Indicates this will require major version update tests/all Run the full test suite. Equivalent to `/packit test`. kind/refactor labels Dec 6, 2024
@has-bot
Copy link
Copy Markdown
Member

has-bot commented Dec 6, 2024

/packit test

Comment generated by an automation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (940e048) to head (472262c).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5176     5176           
  Branches      895      895           
=======================================
  Hits         4975     4975           
  Misses        119      119           
  Partials       82       82
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bocekm bocekm mentioned this pull request Dec 6, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/breaking Indicates this will require major version update kind/refactor tests/all Run the full test suite. Equivalent to `/packit test`.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bocekm @has-bot