-
-
Notifications
You must be signed in to change notification settings - Fork 489
Improve BackendApplicationClient class #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! Yes you're right, Had you got a chance to look at master and see if it fits your needs ? PS: I am in favor of cleaning those parts and the way |
You were right, I hadn't look at master. My fault. I found the recent changes and they address in some way my concerns, but they still have problems, particularly in In other classes I don't know if there is a rational behind this, but it seems that In addition, the same treatment given to
|
Hi @DiegoQueiroz, thanks for the research! a PR increasing the consistency between classes would be greatly appreciated ! Adding a new arg/parameter (e.g. include_kwargs) seems too overkill/or unnecessary, though. |
I think the immediate concern was fixed in #682 and the handling of If someone would like to start a PR/issue with an API changes proposal regarding the Thanks |
Describe the feature
In
BackendApplicationClient
class, theclient_id
,scope
, and**kwargs
parameters passed to the constructor are useless. Notice that evenclient_id
being mandatory, it is not used at all (it is only stored). The**kwargs
parameter, on the other hand, is completely ignored.The
prepare_request_body
method overridesscope
and ignores the one passed to the constructor. The same happens to**kwargs
. This forces me to passclient_id
/scope
/**kwargs
twice (actually, only once, since I can pass anything to the constructor, the result will be the same).Additional context
My suggestion is to override the constructor in the
BackendApplicationClient
subclass with this code (or something similar):This way, the parameters passed to the constructor are used for something, while we keep compatibility with existing code.
The text was updated successfully, but these errors were encountered: