-
-
Notifications
You must be signed in to change notification settings - Fork 493
Open
Description
Describe the bug
Hi there, I'm trying to implement the oidc provider in my framework, but I'm not really clear about the implementation:
The docs state:
get_id_token(token, token_handler, request)
Get OpenID Connect ID token
This method is OPTIONAL and is NOT RECOMMENDED. finalize_id_token SHOULD be
implemented instead. However, if you want a full control over the minting of the
id_token, you MAY want to override get_id_token instead of using finalize_id_token.
Although, further down it says:
validate_jwt_bearer_token(token, scopes, request)
Ensure the JWT Bearer token or OpenID Connect ID token are valids and
authorized access to scopes.
If using OpenID Connect this SHOULD call oauthlib.oauth2.RequestValidator.get_id_token
But if it's not implemented or I don't want to customize it, how SHOULD I call it?
Even if I'd implement it the very same way as grant_types.py:GrantTypeBase.add_id_token
, the nonce
parameter is not passed through to get_id_token
so it cannot easily be implemented the same way.
In general, I find it hard to follow the docs to implement this provider, and would really like to see an example implementation in any framework, which I couldn't find searching everywhere.
Thanks!