Thanks to visit codestin.com
Credit goes to github.com

Skip to content

prompt=none is not handled correctly #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nsklikas opened this issue Apr 27, 2021 · 0 comments · Fixed by #757
Closed

prompt=none is not handled correctly #756

nsklikas opened this issue Apr 27, 2021 · 0 comments · Fixed by #757

Comments

@nsklikas
Copy link
Contributor

Describe the bug
The behavior for handling prompt=none described in the OIDC spec (https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest) is:

  • If prompt=none, return error it user isn't authenticated
  • If prompt=none + something else then return an error.

The current implementation raises an OIDCNoPrompt exception whenever we get prompt=none, the code to properly handle the exists in https://github.com/oauthlib/oauthlib/blob/master/oauthlib/openid/connect/core/grant_types/base.py#L302

Expected behavior

The functions validate_silent_login and validate_silent_authorization must be called and the proper errors must be raised
@nsklikas nsklikas changed the title prompt=none prompt=none is not handled correctly Apr 27, 2021
@nsklikas nsklikas mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly handle prompt=none nsklikas/oauthlib
1 participant
@nsklikas