Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Request object not given to confirm_redirect_uri #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2018
Merged

Request object not given to confirm_redirect_uri #504

merged 2 commits into from
Apr 13, 2018

Conversation

jimmy-lt
Copy link
Contributor

It seems that the request object is never given to the confirm_redirect_uri.

$ git grep -l confirm_redirect_uri oauthlib
oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
oauthlib/oauth2/rfc6749/request_validator.py
$ grep -A 1 confirm_redirect_uri oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
        if not self.request_validator.confirm_redirect_uri(request.client_id, request.code,
                                                           request.redirect_uri, request.client):

This is an issue since I enclose the database session within the request object. That means that I cannot proceed with the query to fulfill the request.

@skion
Copy link
Member

skion commented Dec 12, 2017

I see no reason not to do this: It aligns the validator signature with most of the others without a breaking change. 👍

@skion skion added this to the 2.1.0 milestone Mar 18, 2018
JonathanHuot
JonathanHuot approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report.
It seems the be the only method which doesn't have request. Odd!

LGTM

@skion skion self-requested a review March 29, 2018 18:03
@skion skion merged commit d49b9f0 into oauthlib:master Apr 13, 2018
skion pushed a commit to skion/oauthlib that referenced this pull request Apr 23, 2018
@jimmy-lt @skion
Add request argument to confirm_redirect_uri (oauthlib#504) (oauthlib…
1140d78 
…#504)

(cherry picked from commit d49b9f0)
@skion skion mentioned this pull request May 8, 2018
Closed
@skion skion mentioned this pull request May 21, 2018
Merged
@JonathanHuot JonathanHuot mentioned this pull request Dec 3, 2018
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skion skion skion approved these changes

@JonathanHuot JonathanHuot JonathanHuot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmy-lt @skion @JonathanHuot