fix: demote misleading LibreOffice 'not found' warning to debug (closes HKUDS#230)

jwchmodx · jwchmodx · commit 1daa8176d659 · 2026-04-03T12:20:19.000+09:00
On systems where only 'soffice' is on PATH (common on macOS), the
existing fallback loop logged a WARNING for the 'libreoffice' candidate
before successfully converting via 'soffice'.  This caused users to see:

  WARNING: LibreOffice command 'libreoffice' not found
  INFO:    Successfully converted file.pptx to PDF using soffice

…and conclude that something was broken, even though the conversion
succeeded.

Fix: log FileNotFoundError at DEBUG level for any non-final candidate
so that routine 'libreoffice' → 'soffice' fallback stays silent in
normal logs.  The WARNING is preserved only when the last candidate in
the list is not found (meaning no usable LibreOffice binary exists at
all and the conversion is about to fail).
diff --git a/raganything/parser.py b/raganything/parser.py
@@ -146,7 +146,9 @@ def convert_office_to_pdf(
                 commands_to_try = ["libreoffice", "soffice"]
 
                 conversion_successful = False
+                last_cmd = commands_to_try[-1]
                 for cmd in commands_to_try:
+                    is_last = cmd == last_cmd
                     try:
                         convert_cmd = [
                             cmd,
@@ -188,7 +190,17 @@ def convert_office_to_pdf(
                                 f"LibreOffice command '{cmd}' failed: {result.stderr}"
                             )
                     except FileNotFoundError:
-                        cls.logger.warning(f"LibreOffice command '{cmd}' not found")
+                        # Only warn when all candidates are exhausted; otherwise
+                        # log at debug level so that the normal fallback from
+                        # 'libreoffice' → 'soffice' does not surface a spurious
+                        # WARNING to users whose system only has 'soffice'.
+                        if is_last:
+                            cls.logger.warning(f"LibreOffice command '{cmd}' not found")
+                        else:
+                            cls.logger.debug(
+                                f"LibreOffice command '{cmd}' not found, "
+                                f"trying next candidate"
+                            )
                     except subprocess.TimeoutExpired:
                         cls.logger.warning(f"LibreOffice command '{cmd}' timed out")
                     except Exception as e:
