-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[IMP] ecommerce: catalog update #13668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a36e93c
to
1af4228
Compare
f721ffa
to
a538c79
Compare
5492131
to
a820284
Compare
a820284
to
73af89f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lman-odoo, thank you so much for your work on this! 🙂 I know it wasn’t easy given the overall state of the eCommerce docs, but you did a great job restructuring this page and moving the relevant content over from the Products doc. I really appreciate it!
That said, I have a few suggestions:
-
I think we should maybe adapt the structure slightly: it's a bit weird to only have one h2 so I'd recommend getting rid of it entirely and having the H3s become H2s instead. In addition, Product categories and Attributes are not specific to the side panel; they can also be used/displayed in the top bar so we should probably move those sections as well. I'd also add a section about "Ecommerce access restriction" (see my very last comment about this).
-
I wonder if we should really repeat "go to the shop page, click Edit, and navigate to the Customize tab" so many times in this doc. Maybe we could mention it somewhere at the beginning (after the intro for sure) saying "The shop page/catalog is customized using the website editor. To access it, go to the shop page/catalog, click Edit, and navigate to the Customize tab. Then, we could just say "in the website editor" when we talk about the different options. What do you think?
-
I find it a bit confusing when we talk about: (main) shop page, catalog, category page, product page. At first, I thought these were all the same thing but I think I now understand that shop page= catalog but category page= something else, and product page should be the individual product page, which we don't describe here. I think it would help to clarify this somewhere, maybe at the start of the Product Listing Area section? (see my comment on line 152 as well). We could explain that it’s possible to customize the layout of either the full shop page or an individual category page, and mention that the relevant page needs to be selected first before editing in the website editor. Also, I'd suggest using a single consistent term throughout to talk about the same thing (e.g., “shop page” or “catalog,” but not both, and definitely not “products page”).
-
For anchor names, we usually try to use this format: app name/file name/anchor name (e.g.: ecommerce/catalog/categories)
I know that’s quite a few comments (many of them are related to the same thing 😉), so let me know if anything’s unclear or if you’d like to discuss further.
Thanks again!
.. tip:: | ||
Adding content to an eCommerce category page is beneficial in terms of **SEO** strategy. Using | ||
**keywords** linked to the products or the eCommerce categories improves organic traffic. | ||
Additionally, each category has its own specific URL that can be pointed to and is indexed by | ||
search engines. | ||
Go to :menuselection:`Website --> Configuration --> Settings`, scroll down to the | ||
:guilabel:`Privacy` section to restrict :guilabel:`Ecommerce Access` to :guilabel:`Logged in | ||
users` or to grant access for :guilabel:`All users`. Tick the | ||
:guilabel:`Shared Customer Accounts` checkbox to allow access to all websites with a single | ||
account. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this info gets a bit lost here at the bottom of the doc page in a tip. I think I would maybe add a new section "Ecommerce access restriction" or something like this, at the beginning of the doc page (it is quite important).
Let's discuss this maybe?
:guilabel:`Products Page` category, click on the feature buttons you wish to use. All three buttons | ||
appear when hovering the mouse over a product's image. | ||
You can access and enable additional feature buttons such as a :guilabel:`Add to cart` or | ||
:guilabel:`Wishlist` button or a :guilabel:`comparison list`. To do so, go to the main shop page, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:guilabel:`Wishlist` button or a :guilabel:`comparison list`. To do so, go to the main shop page, | |
:guilabel:`Wishlist` button or a :guilabel:`Comparison list`. To do so, go to the main shop page, |
-
The Wishlist and Comparison list buttons are only available for enabling if you have enabled the related features in the Website settings (Wishlist and Product comparison tool, respectively)
-
On that subject, I think the Product comparison section on the Products doc page could also be moved to this Catalog page, what do you think?
-
I would also maybe add a Wishlist section under "Additional features" with a structure similar to the Product comparison section. I would also mention the fact that customers can add a product to their wishlist from the cart as well (by clicking Save for later). We were wondering earlier where we could document the Wishlist and I think that right now, this might be the best option. Let's discuss this!
My thought process for explaining both those options on the Catalog page is they both involve several products so it would make sense (to be at leadt 😅). What do you think? I know those buttons can also be displayed on individual product pages, so I'd keep the info here in any case.
45f774a
to
941dcb4
Compare
248e996
to
d0cfb74
Compare
.. important:: | ||
The access rights for the ecommerce shop can be configured by going to | ||
:menuselection:`Website --> Configuration --> Settings`, scrolling down to the | ||
:guilabel:`Privacy` section to restrict :guilabel:`Ecommerce Access` to :guilabel:`Logged in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auva-odoo I just saw this task https://www.odoo.com/odoo/project/3835/tasks/4459675 about customer accounts. Wouldn't it be even better to include the information on that page? https://www.odoo.com/documentation/master/applications/websites/ecommerce/customer_accounts.html
811d370
to
7a69ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @lman-odoo. The structure looks much better now!! I have a few more comments (especially since you added new content since the last review, thank you for spotting that and taking care of it in this PR!).
Let me know if you have a any questions 🙂
0f3339e
to
5f42f69
Compare
task-4904299 and task-4311219
5f42f69
to
f8a123b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience @lman-odoo !
@robodoo r+
task-4311219