-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[IMP] pos/viva: Update Viva.com doc #13848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @emmi-odoo for this PR! I added a few comments and suggestion, including one about restructuring the configuration part of the doc. Let me know if you'd like to discuss it!
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
70119c7
to
f201012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this review @emmi-odoo, this version is a lot clearer and more straightforward, nice work! I added a few more comments and suggestions.
Also, I think the official name is viva.com (lower case) but I feel like sometimes with offical names that are not capitalize, they get lost a little bit in the text. I'll let you decide what you want to do in this case, but let's use the same terminology + capitalization throughout the whole doc here for consistency (and replace all of the "Viva" by "viva.com" at least, including in the terminal name 🙂 ).
I noticed that "Viva Wallet" is still used in some places in Odoo but if I’m not mistaken, it was changed to "Viva.com" in 18.3. We can update the documentation accordingly in the fw-port.
Thank you!
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/viva_com.rst
Outdated
Show resolved
Hide resolved
4420a01
to
5902a7f
Compare
task-4745855
5902a7f
to
0175278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @emmi-odoo, thank you for the changes! I force-pushed some more minor ones
@robodoo r+
task-4745855