-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[IMP] Inventory: Fedex Configuration update #13955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @slinkous this is ready for peer review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR really delivers ;). Very minor suggestions.
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Outdated
Show resolved
Hide resolved
2a44fed
to
6df0ac5
Compare
Hey @Felicious this is ready for tech review (I tagged the expert in the task card as well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need two quick things:
- add the section the expert requested
- changing delivery connector back to shipping connector since that's how it's portrayed in the UI. (Changing shipping methods to delivery methods sounds good to me!)
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Outdated
Show resolved
Hide resolved
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Outdated
Show resolved
Hide resolved
6df0ac5
to
c200006
Compare
@Felicious ready for another round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jero-odoo !
Approved with a single typo @robodoo delegate+
...nt/applications/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/fedex.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Zaz Linkous <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
0013f3f
to
a7fe3a3
Compare
@robodoo r+ |
@jero-odoo you can't review+. |
Trying again. @jero-odoo @robodoo delegate+ |
@robodoo r+ |
Docs task: https://www.odoo.com/odoo/project.task/4905285
Updating FedEx configuration doc to reflect updated UI/setup process.