-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ADD] ecommerce/google merchant center: new page #13957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: saas-18.3
Are you sure you want to change the base?
[ADD] ecommerce/google merchant center: new page #13957
Conversation
a188442
to
abc7ae9
Compare
d92f597
to
c116d27
Compare
task-4806648
c116d27
to
4f80ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this @lman-odoo!! I added a few comments and suggestions, don't hesitate if there's anything you'd like to discuss or if something isn't clear!
#. Go through the tasks to provide additional business information or click :guilabel:`Do it later` | ||
to access the dashboard directly. | ||
|
||
Site ownership verification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Site ownership verification is already explained on the Google Search console doc page (with some relevant links, etc.). However, verification using an HTML tag like you describe here is not explained in much detail (only with a link to the Google help page). Therefore, I suggest the following:
- Move the content about the HTML tag (taking into account my comments below) to the Google Search Console doc page, not mentioning GMC at all; just keep it general about GSC + code injection in Odoo).
- Remove the heading, and add the relevant steps to the list above, taking into account my comments below.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do it like this, no problem
.. important:: | ||
Make sure to select all the countries where you intend to sell your products. You are not | ||
able to proceed without selecting at least one target country. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I was just taking a look out of curiosity. Nice work, honestly!
I just noticed that you didn't detail the process to localize the product descriptions and prices/currency? I’m guessing that you simply didn't know, as I didn't make it clear at all in Odoo, so no worries. But it’s quite an important detail for larger eCommerce, so IMHO it’s important to let the user know it’s possible in some sort of "Expert" section or notes. wdyt?
Also, I had added a link in Odoo to the documentation, but I used a temporary link, and I don't think it will match with this PR. So you might have to update the code. Here is a link to where the change would be.
And massive thanks for the work!
To connect your ecommerce with the :abbr:`GMC (Google Merchant Center)` platform, proceed as | ||
follows: | ||
|
||
#. First, go the `Google Merchant Center page <https://business.google.com/us/merchant-center/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#. First, go the `Google Merchant Center page <https://business.google.com/us/merchant-center/>`_. | |
#. First, go to the `Google Merchant Center page <https://business.google.com/us/merchant-center/>`_. |
@lipiraux thank you for taking the time to have a look at this PR, you input is much appreciated!
Just to be sure, are you referring to the content you had in the "Localized feeds" section in your PR? If so, we can definitely integrate it here if you think it's important 🙂. cc @lman-odoo |
yes, thank you 😊 |
task-4806648