Fixed windows TASKKILL so it actually does something *silently*

Byron · Byron · commit 5593dc014a41 · 2009-11-05T18:22:29.000+01:00
diff --git a/lib/git/cmd.py b/lib/git/cmd.py
@@ -63,7 +63,10 @@ def __del__(self):
 				os.kill(self.proc.pid, 2)	# interrupt signal
 			except AttributeError:
 				# try windows 
-				subprocess.call(("TASKKILL", "/T", "/PID", self.proc.pid))
+				# for some reason, providing None for stdout/stderr still prints something. This is why 
+				# we simply use the shell and redirect to nul. Its slower than CreateProcess, question 
+				# is whether we really want to see all these messages. Its annoying no matter what.
+				subprocess.call(("TASKKILL /F /T /PID %s > nul" % str(self.proc.pid)), shell=True)
 			# END exception handling 
 			
 		def __getattr__(self, attr):
