unlink exception during utpdated files cleanup#49
Merged
Conversation
Contributor
Author
|
Here is how you can debug the exception: Also would like o thank you for the plugin. |
|
Yes, the unlink is causing an exception to be thrown because it cannot unlink the "." and ".." shortcuts on a unix based system. |
Owner
|
My bad, I missed it (wish you can add as unread some PR or a better clue on the dashboard) |
thom4parisot
pushed a commit
that referenced
this pull request
Dec 6, 2013
unlink exception during utpdated files cleanup
Owner
|
Thanks for the fix :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was using your plugin for a while and noticed some exceptions
ErrorException [ Warning ]: unlink(/var/www/darth/html/wp-content/uploads/wp-less/my-theme/..): Is a directory
/var/www/wordpress-site/html/wp-content/plugins/wp-less/lib/Garbagecollector.class.php [ 118 ]
113 * @param array $files
114 * @return array
115 */
116 protected function deleteFiles(array $files)
117 {
118 return array_map('unlink', $files);
119 }
120 }
I've fixed the Error by adding:
$dir->setFlags(RecursiveDirectoryIterator::SKIP_DOTS);
for RecursiveDirectoryIterator to skip the Dots during iteration.