[BUG] The pass "eliminate_nop_reshape" causes output mismatch #282
Description
[BUG] The pass "eliminate_nop_reshape" causes output mismatch
Issue
Running the single pass eliminate_nop_reshape with onnxoptimizer 0.4.2 changes numerical outputs.
Environment
- Ubuntu 20.04
- Python 3.10
- onnx==1.19.0
- onnxruntime==1.23.2
- onnxoptimizer==0.4.2(latest)
Repro steps (run from this folder)
eliminate_nop_reshape_repro.tar.gz
- Create a Python environment (Python 3.10) and install dependencies:
python3 -m venv .venv
source .venv/bin/activate
pip install -U pip
pip install -r requirements.txt
- Optimize a case with only
eliminate_nop_reshape(writesmodel.opt.onnxnext tomodel.onnx):
python optimize_model.py --case ./case_03140_seed45116679
- Differential test original and optimized models with the same oracle inputs (ORT graph optimization disabled):
python diff_test.py --case ./case_03140_seed45116679
Expected
eliminate_nop_reshape should be semantics-preserving. Applying this pass alone should not change any output values.
Differential Test Output Details
- case_03140_seed45116679 — mismatch; output[14] max_abs=4.022e+04 max_rel=4.022e+12, output[15] max_abs=5.190e+02 max_rel=5.120e+10; overall mismatch.
- case_00324_seed22816775 — mismatch; output[3] max_abs=5.022e+18 max_rel=1.000e+00; overall mismatch.
Case: case_03140_seed45116679 (ORT graph optimizations disabled)
output[0]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 21)
output[1]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(2, 1, 24)
output[2]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(42336,)
output[3]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 21, 24)
output[4]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(21, 1)
output[5]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(21, 1)
output[6]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(21, 1)
output[7]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(2, 24)
output[8]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 24)
output[9]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 24)
output[10]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 24)
output[11]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 24)
output[12]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(21, 24)
output[13]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(24, 21, 1)
output[14]: max_abs=4.022e+04, max_rel=4.022e+12, shape=(1, 21, 24)
output[15]: max_abs=5.190e+02, max_rel=5.120e+10, shape=(32, 21, 24)
Overall: max_abs=4.022e+04, max_rel=4.022e+12
Case: case_00324_seed22816775 (ORT graph optimizations disabled)
output[0]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 1, 1, 1)
output[1]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 1, 1)
output[2]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 1, 1, 51)
output[3]: max_abs=5.022e+18, max_rel=1.000e+00, shape=(51, 1, 1, 1)
output[4]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1,)
output[5]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 1, 1, 51)
output[6]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(255,)
output[7]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 2, 51)
output[8]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 2, 1)
output[9]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 1, 1, 51)
output[10]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 1, 1)
output[11]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 2, 51)
output[12]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(1, 30, 29, 51)
output[13]: max_abs=0.000e+00, max_rel=0.000e+00, shape=(51, 29, 30)
Overall: max_abs=5.022e+18, max_rel=1.000e+00
Attachments
requirements.txtoptimize_model.pydiff_test.py(runs original and optimized with same oracle inputs; ORT graph optimizations disabled)run_optimized_model.py(executes optimized model with oracle inputs)case_03140_seed45116679/,case_00324_seed22816775/(original models and oracle inputs)