-
Notifications
You must be signed in to change notification settings - Fork 744
Closed
Labels
discussionIssue or PR that needs/is extended discussion.Issue or PR that needs/is extended discussion.metaRelated to repo itself, process, community, ...Related to repo itself, process, community, ...
Description
In #14 we decided not to support Python 2. But with the current code base, we do not even support 3.6, even though setup.py
claims we support 3.4. While it would be nice to be on 3.7 only, I think we should at the very least support 3.6. Demo:
user@pc:~/opentelemetry-python/opentelemetry-api$ cat /etc/issue.net
Ubuntu 18.04.2 LTS
user@pc:~/opentelemetry-python/opentelemetry-api$ python3 --version # Note that this is the latest Python version in this Ubuntu version
Python 3.6.8
user@pc:~/opentelemetry-python/opentelemetry-api$ python3 -c 'import opentelemetry.trace'
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/mnt/c/workspaces/misc/opentelemetry-python/opentelemetry-api/opentelemetry/trace/__init__.py", line 65
from __future__ import annotations
^
SyntaxError: future feature annotations is not defined
This is PEP 563 which requires 3.7.
Type hints in general seem to be supported since 3.5 / PEP 484. But note that instance/class variable type hints would only be available since 3.6 (PEP 526).
Metadata
Metadata
Assignees
Labels
discussionIssue or PR that needs/is extended discussion.Issue or PR that needs/is extended discussion.metaRelated to repo itself, process, community, ...Related to repo itself, process, community, ...