CORE/CONTRIB_REPO_SHA should point to an actual SHA instead of main #4305

aabmass · 2024-11-22T16:13:58Z

So that builds are hermetic.

See

Lines 13 to 14 in a94eab9

    
           CORE_REPO_SHA: main 
        
           CONTRIB_REPO_SHA: main

aabmass · 2024-11-22T16:44:48Z

We should be able to remove some special cases from workflow files once this is fixed:

opentelemetry-python/.github/workflows/changelog.yml

Line 17 in a94eab9

!contains(github.event.pull_request.labels.*.name, 'Skip Changelog')
opentelemetry-python/.github/workflows/misc_0.yml

Line 113 in a94eab9

github.event.pull_request.user.login != 'opentelemetrybot' && github.event_name == 'pull_request'
Possibly

opentelemetry-python/.github/workflows/check-links.yml

Line 27 in a94eab9

github.event.pull_request.user.login != 'opentelemetrybot' && github.event_name == 'pull_request'

aabmass · 2024-11-22T20:36:01Z

I can take this if no one else has started

aabmass added enhancement New feature or request build & infra Issues related to build & infrastructure. labels Nov 22, 2024

aabmass self-assigned this Nov 25, 2024

aabmass removed their assignment May 5, 2025

Provide feedback