From 4ca28d6e7faa11736e39ab31a4ebd09ae8f6bba6 Mon Sep 17 00:00:00 2001 From: jakemalachowski Date: Thu, 16 Jan 2020 10:42:52 -0500 Subject: [PATCH 1/2] Add valid sequence values to AttributeValue type --- opentelemetry-api/src/opentelemetry/util/types.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/opentelemetry-api/src/opentelemetry/util/types.py b/opentelemetry-api/src/opentelemetry/util/types.py index 28fab893890..d3336e15e56 100644 --- a/opentelemetry-api/src/opentelemetry/util/types.py +++ b/opentelemetry-api/src/opentelemetry/util/types.py @@ -13,7 +13,16 @@ # limitations under the License. -import typing +from typing import Union, Optional, Dict, Sequence -AttributeValue = typing.Union[str, bool, float] -Attributes = typing.Optional[typing.Dict[str, AttributeValue]] +AttributeValue = Union[ + str, + bool, + int, + float, + Sequence[str], + Sequence[bool], + Sequence[int], + Sequence[float], +] +Attributes = Optional[Dict[str, AttributeValue]] From 33bfc00b11f06b5d429bdbe9ff8ecb80a47e6219 Mon Sep 17 00:00:00 2001 From: jakemalachowski Date: Fri, 17 Jan 2020 07:02:05 -0500 Subject: [PATCH 2/2] Run linter --- opentelemetry-api/src/opentelemetry/util/types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opentelemetry-api/src/opentelemetry/util/types.py b/opentelemetry-api/src/opentelemetry/util/types.py index d3336e15e56..5ce93d84b25 100644 --- a/opentelemetry-api/src/opentelemetry/util/types.py +++ b/opentelemetry-api/src/opentelemetry/util/types.py @@ -13,7 +13,7 @@ # limitations under the License. -from typing import Union, Optional, Dict, Sequence +from typing import Dict, Optional, Sequence, Union AttributeValue = Union[ str,