Realtime: only update model settings from session #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary: Was running into bugs. Because the model settings were being set from both runner and session, and that was causing issues. Among other things, handoffs were broken because the runner wasn't reading them, and the session wasn't setting them in the connect() call. ### Test Plan: Unit tests.
jhills20
approved these changes
Jul 17, 2025
|
Fantastic! Thank you! I feel so vindicated that I was right. Now I just need to figure out why my interruptions don't work and yours do. |
|
@rm-openai Could these same reasons be why your demos work with interruptions but mine with a custom config doesn't? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Was running into bugs. Because the model settings were being set from both runner and session, and that was causing issues. Among other things, handoffs were broken because the runner wasn't reading them, and the session wasn't setting them in the connect() call.
Test Plan:
Unit tests.