Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ignore errors in isinstance() calls on LazyProxy subclasses #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix: ignore errors in isinstance() calls on LazyProxy subclasses #2343

merged 1 commit into from
May 7, 2025
+16 −1

Conversation

browniebroke
Copy link
Contributor

Fix #2056

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Additional context & links

I assume this might need to be upstreamed in Stainless then?

@RobertCraigie RobertCraigie changed the title fix(internal): handle missing dependency errors in isinstance() calls on LazyProxy subclasses fix: ignore errors in isinstance() calls on LazyProxy subclasses May 7, 2025
@RobertCraigie RobertCraigie changed the base branch from main to next May 7, 2025 16:42
@RobertCraigie RobertCraigie marked this pull request as ready for review May 7, 2025 16:42
@RobertCraigie RobertCraigie requested a review from a team as a code owner May 7, 2025 16:42
@RobertCraigie
Copy link
Collaborator

Thanks! Not sure why CI isn't running...

@browniebroke browniebroke force-pushed the isinstance-missing-dep-error branch from bc07fd3 to 7484400 Compare May 7, 2025 17:21
@browniebroke browniebroke force-pushed the isinstance-missing-dep-error branch from 7484400 to b519b4d Compare May 7, 2025 17:22
@browniebroke
Copy link
Contributor Author

Thanks! Not sure why CI isn't running...

They ran on my fork I think: https://github.com/browniebroke/openai-python/actions/runs/14889434465

RobertCraigie
RobertCraigie approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertCraigie RobertCraigie merged commit 52cbbdf into openai:next May 7, 2025
@stainless-app stainless-app bot mentioned this pull request May 7, 2025
Merged
@browniebroke browniebroke deleted the isinstance-missing-dep-error branch May 7, 2025 19:38
stainless-app bot pushed a commit that referenced this pull request May 8, 2025
@browniebroke @stainless-app
fix: ignore errors in isinstance() calls on LazyProxy subclasses (#2343)
08d67ad 
Fix #2056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie RobertCraigie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing pandas when using isinstance
2 participants
@browniebroke @RobertCraigie