Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor optimization of two lines intersection #24216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Minor optimization of two lines intersection #24216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2ce4c8
Less multiplications in intersectionLines
dkurt Sep 1, 2023
0b70ddc
Less multiplications in intersectLineSegments
dkurt Sep 2, 2023
a4b6319
Add comment
dkurt Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions modules/imgproc/src/geometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,17 +328,16 @@ static LineSegmentIntersection parallelInt( Point2f a, Point2f b, Point2f c, Poi
static LineSegmentIntersection intersectLineSegments( Point2f a, Point2f b, Point2f c,
Point2f d, Point2f& p, Point2f& q )
{
double denom = a.x * (double)(d.y - c.y) + b.x * (double)(c.y - d.y) +
d.x * (double)(b.y - a.y) + c.x * (double)(a.y - b.y);
double denom = (a.x - b.x) * (double)(d.y - c.y) - (a.y - b.y) * (double)(d.x - c.x);

// If denom is zero, then segments are parallel: handle separately.
if( denom == 0. )
return parallelInt(a, b, c, d, p, q);

double num = a.x * (double)(d.y - c.y) + c.x * (double)(a.y - d.y) + d.x * (double)(c.y - a.y);
double num = (d.y - a.y) * (double)(a.x - c.x) + (a.x - d.x) * (double)(a.y - c.y);
double s = num / denom;

num = a.x * (double)(b.y - c.y) + b.x * (double)(c.y - a.y) + c.x * (double)(a.y - b.y);
num = (b.y - a.y) * (double)(a.x - c.x) + (c.y - a.y) * (double)(b.x - a.x);
double t = num / denom;

p.x = (float)(a.x + s*(b.x - a.x));
Expand Down
13 changes: 4 additions & 9 deletions modules/objdetect/src/qrcode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,14 @@ static void updatePointsResult(OutputArray points_, const vector<Point2f>& point

static Point2f intersectionLines(Point2f a1, Point2f a2, Point2f b1, Point2f b2)
{
// Try to solve a two lines intersection (a1, a2) and (b1, b2) as a system of equations:
// a2 + u * (a1 - a2) = b2 + v * (b1 - b2)
const float divisor = (a1.x - a2.x) * (b1.y - b2.y) - (a1.y - a2.y) * (b1.x - b2.x);
const float eps = 0.001f;
if (abs(divisor) < eps)
return a2;
Point2f result_square_angle(
((a1.x * a2.y - a1.y * a2.x) * (b1.x - b2.x) -
(b1.x * b2.y - b1.y * b2.x) * (a1.x - a2.x)) /
divisor,
((a1.x * a2.y - a1.y * a2.x) * (b1.y - b2.y) -
(b1.x * b2.y - b1.y * b2.x) * (a1.y - a2.y)) /
divisor
);
return result_square_angle;
const float u = ((b2.x - a2.x) * (b1.y - b2.y) + (b1.x - b2.x) * (a2.y - b2.y)) / divisor;
return a2 + u * (a1 - a2);
}

// / | b
Expand Down