Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] ArrayView support for HAT kernels #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: code-reflection
Choose a base branch
from
Draft

[WIP] ArrayView support for HAT kernels #571

wants to merge 1 commit into from

Conversation

rbrchen
Copy link
Contributor

@rbrchen rbrchen commented Sep 17, 2025 •
edited by openjdk bot
Loading

Adding an option to read and modify buffers as if they are arrays - e.g. the squares kernel would change from

 @CodeReflection
  public static void kernel(KernelContext kc, S32Arr s32Arr) {
    s32Arr.array(kc.x, s32Arr.array(kc.x) * s32Arr.array(kc.x));
  }

to something like

 @CodeReflection
  public static void kernel(KernelContext kc, S32Arr s32Arr) {
    int[] arr = s32Arr.arrayView();
    arr[kc.x] *= arr[kc.x];
  }

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/571/head:pull/571
$ git checkout pull/571

Update a local copy of the PR:
$ git checkout pull/571
$ git pull https://git.openjdk.org/babylon.git pull/571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 571

View PR using the GUI difftool:
$ git pr show -t 571

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/571.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2025

👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rbrchen