Conversation
The test here was expecting that a prefix of 2 spaces before the replaced element is kept. With new formatting we're cleaning up these spaces. So keep the prefix of the original object (also preserving potential comments before the method that gets replaced)
timtebeek
approved these changes
Nov 25, 2025
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Dec 14, 2025
…22.0 to 3.23.0 [skip ci] [//]: # (dependabot-start)⚠️ \*\*Dependabot is rebasing this PR\*\*⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.22.0 to 3.23.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.23.0 > ------ > > What's Changed > -------------- > > * Migrate Micronaut Nullability annotations to JSpecify nullability annotations by [`@lissam1`](https://github.com/lissam1) in [openrewrite/rewrite-migrate-java#950](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/950) > * Prepare formatting refactor by [`@Jenson3210`](https://github.com/Jenson3210) in [openrewrite/rewrite-migrate-java#951](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/951) > > New Contributors > ---------------- > > * [`@lissam1`](https://github.com/lissam1) made their first contribution in [openrewrite/rewrite-migrate-java#950](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/950) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.22.0...v3.23.0> Commits * [`2dd09ee`](openrewrite/rewrite-migrate-java@2dd09ee) Update tests to reflect removed Sdkman versions * [`95bca99`](openrewrite/rewrite-migrate-java@95bca99) [Auto] SDKMAN! Java candidates as of 2025-12-01T1018 * [`6e10281`](openrewrite/rewrite-migrate-java@6e10281) Include `UseMapOf` with `JavaUtilAPIs` * [`44b4f82`](openrewrite/rewrite-migrate-java@44b4f82) Gradle wrapper 9.2.1 * [`ea84162`](openrewrite/rewrite-migrate-java@ea84162) Prepare formatting refactor ([#951](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/951)) * [`a012744`](openrewrite/rewrite-migrate-java@a012744) Use actions/checkout@v6 * [`4b8525e`](openrewrite/rewrite-migrate-java@4b8525e) [Auto] SDKMAN! Java candidates as of 2025-11-24T1018 * [`c050b14`](openrewrite/rewrite-migrate-java@c050b14) Migrate Micronaut Nullability annotations to JSpecify nullability annotations... * See full diff in [compare view](openrewrite/rewrite-migrate-java@v3.22.0...v3.23.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test here was expecting that a prefix of 2 spaces before the replaced element is kept. With new formatting we're cleaning up these spaces. So keep the prefix of the original object (also preserving potential comments before the method that gets replaced)