Use urllib3 directly instead of requests.packages.urllib3

auniyal61 · auniyal61 · commit 850a4ad429d7 · 2026-05-28T16:05:12.000+05:30
fixes mypy error: Module has no attribute "urllib3".

Import urllib3 directly to fix type checking after change
I59f76d7c36af198b414114357cdc734b64d74b17 removed the type ignore
comment.

Change-Id: I3404f866543813a43301dc3f2ca8a7e6172e7c79
Signed-off-by: Amit Uniyal &lt;auniyal@redhat.com&gt;
diff --git a/cinder/volume/manager.py b/cinder/volume/manager.py
@@ -55,8 +55,8 @@
 from oslo_utils import uuidutils
 from oslo_versionedobjects import fields as ovo_fields
 profiler = importutils.try_import('osprofiler.profiler')
-import requests
 from taskflow import exceptions as tfe
+import urllib3
 
 from cinder.backup import rpcapi as backup_rpcapi
 from cinder.common import constants
@@ -304,9 +304,9 @@ def __init__(self, volume_driver=None, service_name: Optional[str] = None,
 
         if self.configuration.suppress_requests_ssl_warnings:
             LOG.warning("Suppressing requests library SSL Warnings")
-            rpu = requests.packages.urllib3
-            rpu.disable_warnings(rpu.exceptions.InsecureRequestWarning)
-            rpu.disable_warnings(rpu.exceptions.InsecurePlatformWarning)
+            urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
+            urllib3.disable_warnings(
+                urllib3.exceptions.InsecurePlatformWarning)
 
         self.key_manager = key_manager.API(CONF)
         self.driver = importutils.import_object(
