Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix some minor issues with tests #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: fix some minor issues with tests #226

merged 1 commit into from
Apr 1, 2025

Conversation

@dwalluck
Copy link
Contributor

@dwalluck dwalluck commented Mar 31, 2025

  • Remove public modifier
  • Remove exceptions which are not thrown
  • Print test description if there is an unexpected failure

@dwalluck
fix: fix some minor issues with tests
a8f47e6 
* Remove `public` modifier
* Remove exceptions which are not thrown
* Print test description if there is an unexpected failure
jeremylong
jeremylong approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 700b2af into package-url:master Apr 1, 2025
3 checks passed
@dwalluck dwalluck deleted the tests-remove-exceptions branch April 15, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremylong jeremylong jeremylong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dwalluck @jeremylong