Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Remove skip for mpl 1.5 / current dev #8402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
TomAugspurger opened this issue Sep 27, 2014 · 3 comments
Closed
1 of 2 tasks

TST: Remove skip for mpl 1.5 / current dev #8402

TomAugspurger opened this issue Sep 27, 2014 · 3 comments
Labels
good first issue Testing pandas testing functions or related to the test suite Visualization plotting

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Sep 27, 2014 •
edited
Loading

Follow up to #8398

This can be done now.

Remove

pandas/pandas/tests/plotting/test_boxplot_method.py

Lines 24 to 31 in 30eb48c

def _skip_if_mpl_14_or_dev_boxplot():
# GH 8382
# Boxplot failures on 1.4 and 1.4.1
# Don't need try / except since that's done at class level
import matplotlib
if LooseVersion(matplotlib.__version__) >= LooseVersion('1.4'):
pytest.skip("Matplotlib Regression in 1.4 and current dev.")

and its use in

pandas/pandas/tests/plotting/test_boxplot_method.py

Line 158 in 30eb48c

_skip_if_mpl_14_or_dev_boxplot()

Keep an eye on matplotlib/matplotlib#3571 and matplotlib/matplotlib#3544
@TomAugspurger TomAugspurger added the Testing pandas testing functions or related to the test suite label Sep 27, 2014
@TomAugspurger TomAugspurger added this to the 0.15.1 milestone Sep 27, 2014
@TomAugspurger TomAugspurger mentioned this issue Sep 30, 2014
Merged
@tacaswell
Copy link
Contributor

I think the empty column issue is fixed and I could not reproduce the nan problem

@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@datapythonista datapythonista modified the milestones: Contributions Welcome, Someday Jul 8, 2018
@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

this code has been removed as we now require mpl > 2

@TomAugspurger anything left in this issue?

@TomAugspurger
Copy link
Contributor Author

Should be good.

@TomAugspurger TomAugspurger modified the milestones: Someday, No action Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tacaswell @jreback @TomAugspurger @datapythonista