Merge pull request GoogleCloudPlatform#138 from GoogleCloudPlatform/dgreiman/eventlet

Douglas Greiman · web-flow · commit 0ed01f28e671 · 2017-08-16T13:44:12.000-07:00
Add compatibility test for the 'eventlet' Python package.
diff --git a/build.sh b/build.sh
@@ -150,6 +150,7 @@ for outfile in \
   python-interpreter-builder/Dockerfile \
   runtime-image/Dockerfile \
   tests/benchmark/Dockerfile \
+  tests/eventlet/Dockerfile \
   tests/google-cloud-python/Dockerfile \
   tests/google-cloud-python-system/Dockerfile \
   tests/integration/Dockerfile \
@@ -167,6 +168,9 @@ for file in \
   cp -a "${file}" "builder/gen-dockerfile/${file##scripts/}"
 done
 
+# Make a file available to the eventlet test.
+cp -a scripts/testdata/hello_world/main.py tests/eventlet/main.py
+
 # Build images and push to GCR
 if [ "${build}" -eq 1 ]; then
   echo "Building images"
diff --git a/cloudbuild.yaml b/cloudbuild.yaml
@@ -25,6 +25,10 @@ steps:
     '--config', '/workspace/tests/license-test/license-test.yaml',
     '-v'
     ]
+- # Run compatibility tests
+  name: gcr.io/cloud-builders/docker:latest
+  args: ['build', '--tag=${_DOCKER_NAMESPACE}/python/tests/eventlet:${_TAG}',
+         '--no-cache', '/workspace/tests/eventlet/']
 - # Build image to run google client library unit tests
   name: gcr.io/cloud-builders/docker:latest
   args: ['build', '--tag=${_DOCKER_NAMESPACE}/python/tests/google-cloud-python:${_TAG}',
diff --git a/cloudbuild_library_tests.yaml b/cloudbuild_library_tests.yaml
@@ -12,5 +12,9 @@ steps:
     # Avoid warning about unused substitutions
     'UNUSED1=${_BUILDER_DOCKER_NAMESPACE}',
     ]
+- # Run compatibility tests
+  name: gcr.io/cloud-builders/docker:latest
+  args: ['build', '--tag=${_DOCKER_NAMESPACE}/python/tests/eventlet:${_TAG}',
+         '--no-cache', '/workspace/tests/eventlet/']
 images: [
 ]
diff --git a/runtime-image/resources/apt-packages.txt b/runtime-image/resources/apt-packages.txt
@@ -36,3 +36,5 @@ libsasl2-2
 libsasl2-dev
 libsasl2-modules
 sasl2-bin
+# Needed by eventlet
+netbase
diff --git a/tests/eventlet/.gitignore b/tests/eventlet/.gitignore
@@ -0,0 +1,2 @@
+Dockerfile
+main.py
diff --git a/tests/eventlet/Dockerfile.in b/tests/eventlet/Dockerfile.in
@@ -0,0 +1,13 @@
+FROM ${STAGING_IMAGE}
+LABEL python_version=python3.6
+RUN virtualenv --no-download /env -p python3.6
+
+# Set virtualenv environment variables. This is equivalent to running
+# source /env/bin/activate
+ENV VIRTUAL_ENV /env
+ENV PATH /env/bin:$PATH
+ADD requirements.txt /app/
+RUN pip install -r requirements.txt
+ADD . /app/
+RUN gunicorn -k eventlet -b :$PORT --daemon main:app ; \
+    wget --retry-connrefused --tries=5 http://localhost:$PORT/
diff --git a/tests/eventlet/README.md b/tests/eventlet/README.md
@@ -0,0 +1 @@
+# Test the Python base image against the 'eventlet' library
diff --git a/tests/eventlet/requirements.txt b/tests/eventlet/requirements.txt
@@ -0,0 +1,10 @@
+click==6.7
+enum-compat==0.0.2
+eventlet==0.21.0
+Flask==0.12.2
+greenlet==0.4.12
+gunicorn==19.7.1
+itsdangerous==0.24
+Jinja2==2.9.6
+MarkupSafe==1.0
+Werkzeug==0.12.2

Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,9 @@ steps:`
`12`	`12`	`# Avoid warning about unused substitutions`
`13`	`13`	`'UNUSED1=${_BUILDER_DOCKER_NAMESPACE}',`
`14`	`14`	`]`
	`15`	`+- # Run compatibility tests`
	`16`	`+ name: gcr.io/cloud-builders/docker:latest`
	`17`	`+ args: ['build', '--tag=${_DOCKER_NAMESPACE}/python/tests/eventlet:${_TAG}',`
	`18`	`+ '--no-cache', '/workspace/tests/eventlet/']`
`15`	`19`	`images: [`
`16`	`20`	`]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Test the Python base image against the 'eventlet' library`