Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set balance below existential#1983

Merged
cmichi merged 11 commits into
use-ink:masterfrom
CoinFabrik:set-balance-below-existential
Nov 13, 2024
Merged

Set balance below existential#1983
cmichi merged 11 commits into
use-ink:masterfrom
CoinFabrik:set-balance-below-existential

Conversation

@faculerena

@faculerena faculerena commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • [M] y/n | Does it introduce breaking changes?
  • [N] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Added a check for setting the balance in tests below the existential minimum

Description

Given that accounts with a balance below the existential minimum get reaped, adding a check to prohibit setting balance below seems logical. If this should not be like this, feel free to correct us.

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@XianPaz XianPaz mentioned this pull request Nov 13, 2023
Open
@faculerena faculerena force-pushed the set-balance-below-existential branch 2 times, most recently from 0e4f785 to 81a9ae9 Compare November 15, 2023 14:39
@SkymanOne

SkymanOne commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Please merge master

@cmichi

cmichi commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

@faculerena Could you merge master into your PR or allow me to resolve the conflicts?

@faculerena faculerena requested a review from smiasojed as a code owner November 6, 2024 17:53
@faculerena

faculerena commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

I think its ok now @cmichi

@cmichi

cmichi commented Nov 7, 2024

Copy link
Copy Markdown
Collaborator

@faculerena There are some CI errors, do you see the Details if you click the link?

The cargo fmt issues can be applied automatically by executing cargo +nightly fmt --all locally.

@faculerena

faculerena commented Nov 7, 2024

Copy link
Copy Markdown
Contributor Author

Clippy issues fixed and fmt ran. I think the Dylint issues are the same as the other two.

@cmichi

cmichi commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

Thank you, @faculerena!

@cmichi cmichi merged commit c8f9a75 into use-ink:master Nov 13, 2024
@cmichi cmichi mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmichi cmichi cmichi approved these changes
@ascjones ascjones Awaiting requested review from ascjones
@SkymanOne SkymanOne Awaiting requested review from SkymanOne
@smiasojed smiasojed Awaiting requested review from smiasojed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faculerena @SkymanOne @cmichi