-
Notifications
You must be signed in to change notification settings - Fork 106
Closed
Labels
Description
- [ ] Menu toggle icon should use the icon color - it's currently inheriting the text color and is set to another text color when expanded
- [ ] Disabled menu toggles that are buttons are using both the `disabled` attribute and the class `pf-m-disabled`, when (as far as I can tell) they should only need `:disabled`, which is how it is in v5. Link/div/etc (things that don't support the `disabled` attribute) use `.pf-m-disabled'.
- [ ] Also there seems to be some duplicate logic here - looks like we're applying `.pf-m-disabled` if the disabled param is set and it is not a split button, but then later we're testing for split button, and setting `.pf-m-disabled` if the disabled param is set. https://github.com/patternfly/patternfly/blob/475961851c70f987fbd159b3cdc91101b5dd3395/src/patternfly/components/MenuToggle/menu-toggle.hbs#L20-L32
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Backlog