From b306fc22e7d7ceb977318e5adab4ed38f11f2e0d Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Tue, 29 Aug 2023 08:36:44 -0400 Subject: [PATCH 1/2] chore(DataList): added additional rtl styling --- src/patternfly/components/DataList/data-list.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/patternfly/components/DataList/data-list.scss b/src/patternfly/components/DataList/data-list.scss index 7cc7e88d7c..16b4402c23 100644 --- a/src/patternfly/components/DataList/data-list.scss +++ b/src/patternfly/components/DataList/data-list.scss @@ -405,6 +405,8 @@ // toggle icon rotate .#{$data-list}__toggle-icon { + @include pf-v5-mirror-inline-on-rtl; + height: var(--#{$data-list}__toggle-icon--Height); pointer-events: none; transition: var(--#{$data-list}__toggle-icon--Transition); From 890abb17f587ed384a4b76fdb93d4949dfb14874 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Wed, 30 Aug 2023 10:55:13 -0400 Subject: [PATCH 2/2] Add comment to update notif badge in breaking change --- .../components/NotificationBadge/notification-badge.hbs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/patternfly/components/NotificationBadge/notification-badge.hbs b/src/patternfly/components/NotificationBadge/notification-badge.hbs index d2e5f0d1e0..6396991204 100644 --- a/src/patternfly/components/NotificationBadge/notification-badge.hbs +++ b/src/patternfly/components/NotificationBadge/notification-badge.hbs @@ -14,6 +14,9 @@ {{#if notification-badge--attribute}} {{{notification-badge--attribute}}} {{/if}}> + {{!-- TODO in Breaking Change: Add a wrapper element around the icon to follow + how other components' markup is structured for icons + --}}