Use InvalidXLogRecPtr rather than zero literal

jeltz · jeltz · commit 66ecdcc17d02 · 2025-05-27T14:45:17.000+02:00
This makes the code a bit close to PostgreSQL's style.
diff --git a/contrib/pg_tde/src/access/pg_tde_xlog_smgr.c b/contrib/pg_tde/src/access/pg_tde_xlog_smgr.c
@@ -278,13 +278,13 @@ tdeheap_xlog_seg_read(int fd, void *buf, size_t count, off_t offset,
 	if (!keys)
 	{
 		/* cache is empty, try to read keys from disk */
-		keys = pg_tde_fetch_wal_keys(0);
+		keys = pg_tde_fetch_wal_keys(InvalidXLogRecPtr);
 	}
 
 #ifndef FRONTEND
 	write_key_lsn = pg_atomic_read_u64(&EncryptionState->enc_key_lsn);
 
-	if (write_key_lsn != 0)
+	if (!XLogRecPtrIsInvalid(write_key_lsn))
 	{
 		WALKeyCacheRec *last_key = pg_tde_get_last_wal_key();
 

Original file line number	Diff line number	Diff line change
`@@ -278,13 +278,13 @@ tdeheap_xlog_seg_read(int fd, void *buf, size_t count, off_t offset,`
`278`	`278`	`if (!keys)`
`279`	`279`	`{`
`280`	`280`	`/* cache is empty, try to read keys from disk */`
`281`		`- keys = pg_tde_fetch_wal_keys(0);`
	`281`	`+ keys = pg_tde_fetch_wal_keys(InvalidXLogRecPtr);`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`#ifndef FRONTEND`
`285`	`285`	`write_key_lsn = pg_atomic_read_u64(&EncryptionState->enc_key_lsn);`
`286`	`286`
`287`		`- if (write_key_lsn != 0)`
	`287`	`+ if (!XLogRecPtrIsInvalid(write_key_lsn))`
`288`	`288`	`{`
`289`	`289`	`WALKeyCacheRec *last_key = pg_tde_get_last_wal_key();`
`290`	`290`