[#907] make configuration file error more descriptive#909
Draft
saraanbih wants to merge 1 commit into
Draft
Conversation
0384478 to
1a551c4
Compare
Collaborator
Author
|
Hi Mr. @jesperpedersen PTAL :) |
702bf9d to
40581ba
Compare
| errx(1, "Configuration syntax error in: %s\n" | ||
| "\n" | ||
| "Valid pgmoneta-cli configuration options:\n" | ||
| " - host = hostname (required)\n" |
Member
There was a problem hiding this comment.
Its either host / port or unix_socket_dir -- if -h / -p isn't specified
28b602a to
89c83cf
Compare
remove spaces make the error config message more descriptive add config check for clic and walfilter add more details in error message adjust format fix connection type message
89c83cf to
646eb96
Compare
| } | ||
| else | ||
| { | ||
| snprintf(error_context, sizeof(error_context), |
Member
There was a problem hiding this comment.
Use pgmoneta_snprintf instead
Member
|
@saraanbih Update ? |
Collaborator
Author
I have forgotten it, so I made it a draft until I return to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [#907]