Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Potential race condition #155

@dunglas

Description

@dunglas

https://github.com/dunglas/frankenphp/actions/runs/5378195414/jobs/9757671795

==================
WARNING: DATA RACE
Write at 0x00c002563090 by goroutine 5698:
  runtime.closechan()
      /usr/local/go/src/runtime/chan.go:357 +0x0
  github.com/dunglas/frankenphp.Shutdown()
      /go/src/app/frankenphp.go:297 +0x44
  runtime.deferreturn()
      /usr/local/go/src/runtime/panic.go:476 +0x32
  github.com/dunglas/frankenphp_test.testTimeout()
      /go/src/app/frankenphp_test.go:606 +0x18b
  github.com/dunglas/frankenphp_test.TestTimeout_worker()
      /go/src/app/frankenphp_test.go:598 +0x66
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1493 +0x47

Previous read at 0x00c002563090 by goroutine 5699:
  runtime.chansend()
      /usr/local/go/src/runtime/chan.go:160 +0x0
  github.com/dunglas/frankenphp.ServeHTTP()
      /go/src/app/frankenphp.go:413 +0x464
  github.com/dunglas/frankenphp.startWorkers.func1()
      /go/src/app/worker.go:67 +0x3d5

Goroutine 5698 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1726 +0xa84
  main.main()
      _testmain.go:139 +0x2e9

Goroutine 5699 (running) created at:
  github.com/dunglas/frankenphp.startWorkers()
      /go/src/app/worker.go:44 +0x344
  github.com/dunglas/frankenphp.Init()
      /go/src/app/frankenphp.go:284 +0x724
  github.com/dunglas/frankenphp_test.runTest()
      /go/src/app/frankenphp_test.go:59 +0x506
  github.com/dunglas/frankenphp_test.testTimeout()
      /go/src/app/frankenphp_test.go:606 +0x18b
  github.com/dunglas/frankenphp_test.TestTimeout_worker()
      /go/src/app/frankenphp_test.go:598 +0x66
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1493 +0x47
==================
    logger.go:130: 2023-06-26T12:41:05.787Z	DEBUG	terminated	{"worker": "/go/src/app/testdata/timeout.php"}
    logger.go:130: 2023-06-26T12:41:05.787Z	DEBUG	terminated	{"worker": "/go/src/app/testdata/timeout.php"}
    logger.go:130: 2023-06-26T12:41:05.789Z	DEBUG	FrankenPHP shut down
    testing.go:1319: race detected during execution of test
--- FAIL: TestTimeout_worker (50.21s)
==================
WARNING: DATA RACE
Write at 0x00c003a90070 by goroutine 5714:
  runtime.closechan()
      /usr/local/go/src/runtime/chan.go:357 +0x0
  github.com/dunglas/frankenphp.Shutdown()
      /go/src/app/frankenphp.go:297 +0x44
  runtime.deferreturn()
      /usr/local/go/src/runtime/panic.go:476 +0x32
  github.com/dunglas/frankenphp_test.testTimeout()
      /go/src/app/frankenphp_test.go:606 +0x18b
  github.com/dunglas/frankenphp_test.TestTimeout_worker()
      /go/src/app/frankenphp_test.go:598 +0x66
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1629 +0x47

Previous read at 0x00c003a90070 by goroutine 5716:
  runtime.chansend()
      /usr/local/go/src/runtime/chan.go:160 +0x0
  github.com/dunglas/frankenphp.ServeHTTP()
      /go/src/app/frankenphp.go:413 +0x464
  github.com/dunglas/frankenphp.startWorkers.func1()
      /go/src/app/worker.go:67 +0x3d5

Goroutine 5714 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1576 +0x216
  testing.runTests()
      /usr/local/go/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1906 +0xb44
  main.main()
      _testmain.go:139 +0x2e9

Goroutine 5716 (running) created at:
  github.com/dunglas/frankenphp.startWorkers()
      /go/src/app/worker.go:44 +0x344
  github.com/dunglas/frankenphp.Init()
      /go/src/app/frankenphp.go:284 +0x833
  github.com/dunglas/frankenphp_test.runTest()
      /go/src/app/frankenphp_test.go:59 +0x4ee
  github.com/dunglas/frankenphp_test.testTimeout()
      /go/src/app/frankenphp_test.go:606 +0x18b
  github.com/dunglas/frankenphp_test.TestTimeout_worker()
      /go/src/app/frankenphp_test.go:598 +0x66
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1629 +0x47
==================
    logger.go:130: 2023-06-26T18:05:40.444Z	DEBUG	shutting down	{"worker": "/go/src/app/testdata/timeout.php"}
    logger.go:130: 2023-06-26T18:05:40.452Z	DEBUG	terminated	{"worker": "/go/src/app/testdata/timeout.php"}
    logger.go:130: 2023-06-26T18:05:40.453Z	DEBUG	terminated	{"worker": "/go/src/app/testdata/timeout.php"}
    logger.go:130: 2023-06-26T18:05:40.457Z	DEBUG	FrankenPHP shut down
    testing.go:1446: race detected during execution of test
--- FAIL: TestTimeout_worker (50.31s)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions