Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make psr/log and psr/cache hard dependencies #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sagikazarmark opened this issue Dec 26, 2015 · 5 comments
Closed

Make psr/log and psr/cache hard dependencies #36

sagikazarmark opened this issue Dec 26, 2015 · 5 comments
Labels
enhancement need-pull-request question
Milestone
v0.1

Comments

@sagikazarmark
Copy link
Member

Those are light, interface packages, probably installed in most projects anyway.
@sagikazarmark sagikazarmark added this to the v0.1 milestone Dec 26, 2015
@joelwurtz
Copy link
Member

👎 Making this a hard dependancy will force user to have a log and cache implementation

@sagikazarmark
Copy link
Member Author

That's not true. I meant the interface packages, not the virtual packages.

@joelwurtz
Copy link
Member

The interface package does not require a virtual package ?

@sagikazarmark
Copy link
Member Author

Nope. And that's how it should be, like on case of HTTPlug: it doesn't require the virtual packages either.

@joelwurtz
Copy link
Member

Oh ok, sounds good to me then

@sagikazarmark sagikazarmark mentioned this issue Dec 26, 2015
Merged
@gjuric gjuric mentioned this issue Feb 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement need-pull-request question
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
2 participants
@joelwurtz @sagikazarmark