Code style && SSL => TLS

cyril-barragan · cyril-barragan · commit d97eed4455a1 · 2025-08-25T16:03:55.000+02:00
diff --git a/src/Protocol/ProtocolEnum.php b/src/Protocol/ProtocolEnum.php
@@ -10,4 +10,5 @@ enum ProtocolEnum: string
     case TCP = 'tcp';
     case TCP4 = 'tcp4';
     case TCP6 = 'tcp6';
+    case TLS = 'tls';
 }
diff --git a/src/Transport/StreamTransport.php b/src/Transport/StreamTransport.php
@@ -41,7 +41,7 @@ public function __construct(
     private function getProtocol(): ProtocolEnum
     {
         if ($this->config->getUseTls()) {
-            return ProtocolEnum::SSL;
+            return ProtocolEnum::TLS;
         } elseif ($this->config->isForceIpv6()) {
             return ProtocolEnum::TCP6;
         } elseif ($this->config->isForceIpv4()) {
@@ -128,22 +128,20 @@ public function close (): void
 
 	public function isOpen (): bool
 	{
-		if (!is_resource($this->socket))
+		if (!is_resource($this->socket)) {
 			return false;
+        }
 
 		$r = null;
 		$w = null;
 		$e = [$this->socket];
 		$res = stream_select($r, $w, $e, 0);
 
-		if ($res === false)
-			throw new SocketTransportException('Could not examine stream');
-
-		// if there is an exception on our stream it's probably dead
-		if (!empty($e))
-			return false;
+		if (false === $res) {
+			throw new SocketTransportException("Stream can't connect");
+        }
 
-		return true;
+		return empty($e);
 	}
 
     public function hasData(): bool
@@ -162,7 +160,7 @@ public function hasData(): bool
     public function read(int $length): string
     {
         if (!$this->socket) {
-            throw new SocketTransportException('Socket is not open');
+            throw new SocketTransportException('Stream is not open');
         }
 
         if (!is_resource($this->socket) || feof($this->socket)) {
@@ -182,11 +180,11 @@ public function read(int $length): string
         if (stream_select($read, $write, $except, $readTimeout['sec'], $readTimeout['usec']) > 0) {
             $data = fread($this->socket, $length);
         } else {
-            throw new SocketTransportException('No answer from server');
+            throw new SocketTransportException('Stream no answer from server');
         }
 
-        if ($data === false) {
-            throw new SocketTransportException('Could not read ' . $length . ' bytes from stream');
+        if (false === $data) {
+            throw new SocketTransportException("Stream could not read $length bytes");
         }
 
         return $data;
@@ -203,8 +201,9 @@ private function millisecToArray(int $milliseconds): array
 
     public function write(string $buffer, int $length): void
     {
-        if (!is_resource($this->socket) || feof($this->socket))
+        if (!is_resource($this->socket) || feof($this->socket)) {
             throw new SocketTransportException('Stream connection error');
+        }
 
         $r = $length;
         $writeTimeout = $this->millisecToArray($this->config->getDefaultSendTimeout());
@@ -215,16 +214,17 @@ public function write(string $buffer, int $length): void
         while ($r > 0) {
             $wrote = fwrite($this->socket, $buffer, $r);
 
-            if ($wrote === false)
-                throw new SocketTransportException('Could not write ' . $length . ' bytes to stream');
+            if (false === $wrote) {
+                throw new SocketTransportException("Stream fail to write $length bytes");
+            }
 
             $r -= $wrote;
-
-            $buffer = substr($buffer, $wrote);
-
+            
             if (0 === $r) {
                 return;
             }
+
+            $buffer = substr($buffer, $wrote);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,5 @@ enum ProtocolEnum: string`
`10`	`10`	`case TCP = 'tcp';`
`11`	`11`	`case TCP4 = 'tcp4';`
`12`	`12`	`case TCP6 = 'tcp6';`
	`13`	`+ case TLS = 'tls';`
`13`	`14`	`}`