SENTINEL RESET returns a long.

michael-grunder · michael-grunder · commit 0243dd9d2a32 · 2022-11-17T22:35:18.000-08:00
diff --git a/redis_sentinel.c b/redis_sentinel.c
@@ -140,7 +140,7 @@ PHP_METHOD(RedisSentinel, ping)
 
 PHP_METHOD(RedisSentinel, reset)
 {
-    REDIS_PROCESS_KW_CMD("reset", redis_sentinel_str_cmd, redis_boolean_response);
+    REDIS_PROCESS_KW_CMD("reset", redis_sentinel_str_cmd, redis_long_response);
 }
 
 PHP_METHOD(RedisSentinel, sentinels)
diff --git a/redis_sentinel.stub.php b/redis_sentinel.stub.php
@@ -33,7 +33,7 @@ public function myid(): string;
 	/** @return bool|RedisSentinel */
     public function ping();
 
-	/** @return bool|RedisSentinel */
+	/** @return int|RedisSentinel */
     public function reset(string $pattern);
 
 	/** @return array|bool|RedisSentinel */
diff --git a/redis_sentinel_arginfo.h b/redis_sentinel_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 4055ace9f1cf20bef89bdb5d3219470b4c8915e6 */
+ * Stub hash: 847c735dfbbb643366344acfe6e2c5e8b76d0520 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RedisSentinel___construct, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, host, IS_STRING, 0)
diff --git a/redis_sentinel_legacy_arginfo.h b/redis_sentinel_legacy_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 4055ace9f1cf20bef89bdb5d3219470b4c8915e6 */
+ * Stub hash: 847c735dfbbb643366344acfe6e2c5e8b76d0520 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_RedisSentinel___construct, 0, 0, 1)
 	ZEND_ARG_INFO(0, host)
diff --git a/tests/RedisSentinelTest.php b/tests/RedisSentinelTest.php
@@ -96,7 +96,7 @@ public function testPing()
 
     public function testReset()
     {
-        $this->assertFalse($this->sentinel->reset('*'));
+        $this->assertEquals(1, $this->sentinel->reset('*'));
     }
 
     public function testSentinels()

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ PHP_METHOD(RedisSentinel, ping)`
`140`	`140`
`141`	`141`	`PHP_METHOD(RedisSentinel, reset)`
`142`	`142`	`{`
`143`		`- REDIS_PROCESS_KW_CMD("reset", redis_sentinel_str_cmd, redis_boolean_response);`
	`143`	`+ REDIS_PROCESS_KW_CMD("reset", redis_sentinel_str_cmd, redis_long_response);`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`PHP_METHOD(RedisSentinel, sentinels)`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function testPing()`
`96`	`96`
`97`	`97`	`public function testReset()`
`98`	`98`	`{`
`99`		`- $this->assertFalse($this->sentinel->reset('*'));`
	`99`	`+ $this->assertEquals(1, $this->sentinel->reset('*'));`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`public function testSentinels()`