Reduce buffer size for signed integer, strlen(-9223372036854775808) = 20 + 1 for '\0'

bentleyo · michael-grunder · commit 044b30386f04 · 2024-12-17T17:08:36.000-08:00
diff --git a/library.c b/library.c
@@ -1060,7 +1060,7 @@ int redis_cmd_append_sstr_long(smart_string *str, long append) {
  * Append a 64-bit integer to our command
  */
 int redis_cmd_append_sstr_i64(smart_string *str, int64_t append) {
-    char nbuf[64];
+    char nbuf[21];
     int len = snprintf(nbuf, sizeof(nbuf), "%" PRId64, append);
     return redis_cmd_append_sstr(str, nbuf, len);
 }

Original file line number	Diff line number	Diff line change
`@@ -1060,7 +1060,7 @@ int redis_cmd_append_sstr_long(smart_string *str, long append) {`
`1060`	`1060`	`* Append a 64-bit integer to our command`
`1061`	`1061`	`*/`
`1062`	`1062`	`int redis_cmd_append_sstr_i64(smart_string *str, int64_t append) {`
`1063`		`- char nbuf[64];`
	`1063`	`+ char nbuf[21];`
`1064`	`1064`	`int len = snprintf(nbuf, sizeof(nbuf), "%" PRId64, append);`
`1065`	`1065`	`return redis_cmd_append_sstr(str, nbuf, len);`
`1066`	`1066`	`}`