No need to execute copy constructor and explicitly delete

michael-grunder · michael-grunder · commit 371ae7aef0b2 · 2020-02-17T17:27:07.000-08:00
diff --git a/library.c b/library.c
@@ -1166,8 +1166,7 @@ static void array_zip_values_and_scores(RedisSock *redis_sock, zval *z_tab,
 
     /* replace */
     zval_dtor(z_tab);
-    ZVAL_ZVAL(z_tab, &z_ret, 1, 0);
-    zval_dtor(&z_ret);
+    ZVAL_ZVAL(z_tab, &z_ret, 0, 0);
 }
 
 static int

Original file line number	Diff line number	Diff line change
`@@ -1166,8 +1166,7 @@ static void array_zip_values_and_scores(RedisSock redis_sock, zval z_tab,`
`1166`	`1166`
`1167`	`1167`	`/* replace */`
`1168`	`1168`	`zval_dtor(z_tab);`
`1169`		`- ZVAL_ZVAL(z_tab, &z_ret, 1, 0);`
`1170`		`- zval_dtor(&z_ret);`
	`1169`	`+ ZVAL_ZVAL(z_tab, &z_ret, 0, 0);`
`1171`	`1170`	`}`
`1172`	`1171`
`1173`	`1172`	`static int`