Issue #1974

yatsukhnenko · yatsukhnenko · commit 42cbd88a185e · 2022-04-02T17:58:52.000+03:00
diff --git a/common.h b/common.h
@@ -332,6 +332,7 @@ typedef struct {
     int                 reply_literal;
     int                 null_mbulk_as_null;
     int                 tcp_keepalive;
+    int                 sentinel;
 } RedisSock;
 /* }}} */
 
diff --git a/library.c b/library.c
@@ -2340,7 +2340,10 @@ redis_sock_check_liveness(RedisSock *redis_sock)
     }
 
     /* check echo response */
-    if (*inbuf != TYPE_BULK || atoi(inbuf + 1) != idlen ||
+    if ((redis_sock->sentinel && (
+        strncmp(inbuf, "-ERR unknown command", 20) != 0 ||
+        strstr(inbuf, id) == NULL
+    )) || *inbuf != TYPE_BULK || atoi(inbuf + 1) != idlen ||
         redis_sock_gets(redis_sock, inbuf, sizeof(inbuf) - 1, &len) < 0 ||
         strncmp(inbuf, id, idlen) != 0
     ) {
diff --git a/redis_sentinel.c b/redis_sentinel.c
@@ -87,6 +87,7 @@ PHP_METHOD(RedisSentinel, __construct)
     if (auth) {
         redis_sock_set_auth_zval(obj->sock, auth);
     }
+    obj->sock->sentinel = 1;
 }
 
 PHP_METHOD(RedisSentinel, ckquorum)

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ PHP_METHOD(RedisSentinel, __construct)`
`87`	`87`	`if (auth) {`
`88`	`88`	`redis_sock_set_auth_zval(obj->sock, auth);`
`89`	`89`	`}`
	`90`	`+ obj->sock->sentinel = 1;`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`PHP_METHOD(RedisSentinel, ckquorum)`