Properly copy the preferred nodes array into our definition

aolley · aolley · commit 5f8117f5047f · 2021-03-04T14:46:09.000+10:30
Without this, we end up with zend_mm_heap issues.
diff --git a/redis_commands.c b/redis_commands.c
@@ -4184,7 +4184,7 @@ void redis_setoption_handler(INTERNAL_FUNCTION_PARAMETERS,
                 zend_hash_destroy(c->preferred_nodes);
                 FREE_HASHTABLE(c->preferred_nodes);
             }
-            c->preferred_nodes = Z_ARRVAL_P(val);
+            c->preferred_nodes = zend_array_dup(Z_ARRVAL_P(val));
             RETURN_TRUE;
         EMPTY_SWITCH_DEFAULT_CASE()
     }

Original file line number	Diff line number	Diff line change
`@@ -4184,7 +4184,7 @@ void redis_setoption_handler(INTERNAL_FUNCTION_PARAMETERS,`
`4184`	`4184`	`zend_hash_destroy(c->preferred_nodes);`
`4185`	`4185`	`FREE_HASHTABLE(c->preferred_nodes);`
`4186`	`4186`	`}`
`4187`		`- c->preferred_nodes = Z_ARRVAL_P(val);`
	`4187`	`+ c->preferred_nodes = zend_array_dup(Z_ARRVAL_P(val));`
`4188`	`4188`	`RETURN_TRUE;`
`4189`	`4189`	`EMPTY_SWITCH_DEFAULT_CASE()`
`4190`	`4190`	`}`