Issue #2122

yatsukhnenko · yatsukhnenko · commit c28ad7bbd6c8 · 2022-07-03T18:33:42.000+03:00
Allow IPv6 address within square brackets
diff --git a/library.c b/library.c
@@ -2340,7 +2340,7 @@ PHP_REDIS_API int redis_sock_connect(RedisSock *redis_sock)
 #ifdef HAVE_IPV6
         /* If we've got IPv6 and find a colon in our address, convert to proper
          * IPv6 [host]:port format */
-        if (strchr(address, ':') != NULL) {
+        if (strchr(address, ':') != NULL && strchr(address, '[') == NULL) {
             fmtstr = "%s://[%s]:%d";
         }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -2340,7 +2340,7 @@ PHP_REDIS_API int redis_sock_connect(RedisSock *redis_sock)`
`2340`	`2340`	`#ifdef HAVE_IPV6`
`2341`	`2341`	`/* If we've got IPv6 and find a colon in our address, convert to proper`
`2342`	`2342`	`* IPv6 [host]:port format */`
`2343`		`- if (strchr(address, ':') != NULL) {`
	`2343`	`+ if (strchr(address, ':') != NULL && strchr(address, '[') == NULL) {`
`2344`	`2344`	`fmtstr = "%s://[%s]:%d";`
`2345`	`2345`	`}`
`2346`	`2346`	`#endif`