Fix overallocation in directed cluster MULTIBULK handling.

michael-grunder · michael-grunder · commit cf93649ec14d · 2019-07-31T13:41:06.000-07:00
Addresses #1611
diff --git a/cluster_library.c b/cluster_library.c
@@ -239,7 +239,7 @@ cluster_read_sock_resp(RedisSock *redis_sock, REDIS_REPLY_TYPE type,
         case TYPE_MULTIBULK:
             r->elements = len;
             if (len != (size_t)-1) {
-                r->element = ecalloc(len, sizeof(clusterReply*)*len);
+                r->element = ecalloc(len, sizeof(clusterReply*));
                 cluster_multibulk_resp_recursive(redis_sock, len, r->element,
                                                  line_reply != NULL, &err);
             }

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ cluster_read_sock_resp(RedisSock *redis_sock, REDIS_REPLY_TYPE type,`
`239`	`239`	`case TYPE_MULTIBULK:`
`240`	`240`	`r->elements = len;`
`241`	`241`	`if (len != (size_t)-1) {`
`242`		`- r->element = ecalloc(len, sizeof(clusterReply)len);`
	`242`	`+ r->element = ecalloc(len, sizeof(clusterReply*));`
`243`	`243`	`cluster_multibulk_resp_recursive(redis_sock, len, r->element,`
`244`	`244`	`line_reply != NULL, &err);`
`245`	`245`	`}`