Issue #1618

yatsukhnenko · yatsukhnenko · commit fbe0f804bc68 · 2019-08-09T15:10:05.000+03:00
This commit fixes regression added in 112c77e
diff --git a/redis_array.c b/redis_array.c
@@ -653,7 +653,7 @@ PHP_METHOD(RedisArray, _continuum)
 static void
 multihost_distribute_call(RedisArray *ra, zval *return_value, zval *z_fun, int argc, zval *argv)
 {
-    zval z_arg, z_tmp;
+    zval z_tmp;
     int i;
 
     /* Init our array return */
@@ -665,7 +665,7 @@ multihost_distribute_call(RedisArray *ra, zval *return_value, zval *z_fun, int a
         ra_call_user_function(&redis_array_ce->function_table, &ra->redis[i], z_fun, &z_tmp, argc, argv);
 
         /* Add the result for this host */
-        add_assoc_zval_ex(return_value, ZSTR_VAL(ra->hosts[i]), ZSTR_LEN(ra->hosts[i]), &z_arg);
+        add_assoc_zval_ex(return_value, ZSTR_VAL(ra->hosts[i]), ZSTR_LEN(ra->hosts[i]), &z_tmp);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -653,7 +653,7 @@ PHP_METHOD(RedisArray, _continuum)`
`653`	`653`	`static void`
`654`	`654`	`multihost_distribute_call(RedisArray ra, zval return_value, zval z_fun, int argc, zval argv)`
`655`	`655`	`{`
`656`		`- zval z_arg, z_tmp;`
	`656`	`+ zval z_tmp;`
`657`	`657`	`int i;`
`658`	`658`
`659`	`659`	`/* Init our array return */`
`@@ -665,7 +665,7 @@ multihost_distribute_call(RedisArray ra, zval return_value, zval *z_fun, int a`
`665`	`665`	`ra_call_user_function(&redis_array_ce->function_table, &ra->redis[i], z_fun, &z_tmp, argc, argv);`
`666`	`666`
`667`	`667`	`/* Add the result for this host */`
`668`		`- add_assoc_zval_ex(return_value, ZSTR_VAL(ra->hosts[i]), ZSTR_LEN(ra->hosts[i]), &z_arg);`
	`668`	`+ add_assoc_zval_ex(return_value, ZSTR_VAL(ra->hosts[i]), ZSTR_LEN(ra->hosts[i]), &z_tmp);`
`669`	`669`	`}`
`670`	`670`	`}`
`671`	`671`