Fix MissingPropertyFromReflectionException when working with Stripe SDK

ondrejmirtes · ondrejmirtes · commit 07a010f0f9bf · 2025-09-12T09:42:17.000+02:00
diff --git a/src/Type/ObjectShapeType.php b/src/Type/ObjectShapeType.php
@@ -173,7 +173,20 @@ public function accepts(Type $type, bool $strictTypes): AcceptsResult
 			}
 
 			$result = $result->and($hasProperty);
-			$otherProperty = $type->getProperty($propertyName, $scope);
+			try {
+				$otherProperty = $type->getProperty($propertyName, $scope);
+			} catch (MissingPropertyFromReflectionException) {
+				return AcceptsResult::createNo(
+					[
+						sprintf(
+							'%s does not have property $%s.',
+							$type->describe(VerbosityLevel::typeOnly()),
+							$propertyName,
+						),
+					],
+				);
+			}
+
 			if (!$otherProperty->isPublic()) {
 				return new AcceptsResult(TrinaryLogic::createNo(), [
 					sprintf('Property %s::$%s is not public.', $otherProperty->getDeclaringClass()->getDisplayName(), $propertyName),
@@ -265,7 +278,19 @@ public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
 			}
 
 			$result = $result->and($hasProperty);
-			$otherProperty = $type->getProperty($propertyName, $scope);
+			try {
+				$otherProperty = $type->getProperty($propertyName, $scope);
+			} catch (MissingPropertyFromReflectionException) {
+				return IsSuperTypeOfResult::createNo(
+					[
+						sprintf(
+							'%s does not have property $%s.',
+							$type->describe(VerbosityLevel::typeOnly()),
+							$propertyName,
+						),
+					],
+				);
+			}
 			if (!$otherProperty->isPublic()) {
 				return IsSuperTypeOfResult::createNo();
 			}
diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -1252,6 +1252,12 @@ public function testDiscussion9053(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug13492(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-13492.php');
+		$this->assertNoErrors($errors);
+	}
+
 	public function testProcessCalledMethodInfiniteLoop(): void
 	{
 		$errors = $this->runAnalyse(__DIR__ . '/data/process-called-method-infinite-loop.php');
diff --git a/tests/PHPStan/Analyser/data/bug-13492.php b/tests/PHPStan/Analyser/data/bug-13492.php
@@ -0,0 +1,57 @@
+<?php
+
+namespace Bug13492;
+
+/**
+ * @property CustomerService $customers
+ */
+class StripeClient
+{
+
+	/**
+	 * @return mixed
+	 */
+	public function __get(string $name)
+	{
+		return $this->getService();
+	}
+
+	public function getService(): CustomerService
+	{
+		return new CustomerService();
+	}
+
+}
+
+class CustomerService
+{
+
+	public function create(): Customer
+	{
+		return new Customer();
+	}
+
+}
+
+/**
+ * @property null|(object{address?: (object{city: null|string, country: null|string, line1: null|string, line2: null|string, postal_code: null|string, state: null|string}&StripeObject), carrier?: null|string, name?: string, phone?: null|string, tracking_number?: null|string}&StripeObject) $shipping Mailing and shipping address for the customer. Appears on invoices emailed to this customer.
+ * @property null|(object{city: null|string, country: null|string, line1: null|string, line2: null|string, postal_code: null|string, state: null|string}&StripeObject) $address The customer's address.
+ */
+class Customer extends StripeObject
+{
+
+}
+
+class StripeObject
+{
+	/** @return mixed */
+	public function &__get(string $k)
+	{
+
+	}
+}
+
+function (): void {
+	$stripe = new StripeClient();
+	$customer = $stripe->customers->create();
+};

Original file line number	Diff line number	Diff line change
`@@ -1252,6 +1252,12 @@ public function testDiscussion9053(): void`
`1252`	`1252`	`$this->assertNoErrors($errors);`
`1253`	`1253`	`}`
`1254`	`1254`
	`1255`	`+ public function testBug13492(): void`
	`1256`	`+ {`
	`1257`	`+ $errors = $this->runAnalyse(__DIR__ . '/data/bug-13492.php');`
	`1258`	`+ $this->assertNoErrors($errors);`
	`1259`	`+ }`
	`1260`	`+`
`1255`	`1261`	`public function testProcessCalledMethodInfiniteLoop(): void`
`1256`	`1262`	`{`
`1257`	`1263`	`$errors = $this->runAnalyse(__DIR__ . '/data/process-called-method-infinite-loop.php');`