Move readonly checks into hasRestrictedWriteAccess method

phpstan-bot · claude · phpstan-bot · commit b25e1e716036 · 2026-04-10T11:57:17.000Z
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Rules/Generics/PropertyVarianceRule.php b/src/Rules/Generics/PropertyVarianceRule.php
@@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$variance = $node->isReadOnly() || $node->isReadOnlyByPhpDoc() || $this->hasRestrictedWriteAccess($node)
+		$variance = $this->hasRestrictedWriteAccess($node)
 			? TemplateTypeVariance::createCovariant()
 			: TemplateTypeVariance::createInvariant();
 
@@ -58,6 +58,10 @@ public function processNode(Node $node, Scope $scope): array
 
 	private function hasRestrictedWriteAccess(ClassPropertyNode $node): bool
 	{
+		if ($node->isReadOnly() || $node->isReadOnlyByPhpDoc()) {
+			return true;
+		}
+
 		if ($node->isPrivateSet()) {
 			return true;
 		}

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function processNode(Node $node, Scope $scope): array`
`45`	`45`	`return [];`
`46`	`46`	`}`
`47`	`47`
`48`		`- $variance = $node->isReadOnly() \|\| $node->isReadOnlyByPhpDoc() \|\| $this->hasRestrictedWriteAccess($node)`
	`48`	`+ $variance = $this->hasRestrictedWriteAccess($node)`
`49`	`49`	`? TemplateTypeVariance::createCovariant()`
`50`	`50`	`: TemplateTypeVariance::createInvariant();`
`51`	`51`
`@@ -58,6 +58,10 @@ public function processNode(Node $node, Scope $scope): array`
`58`	`58`
`59`	`59`	`private function hasRestrictedWriteAccess(ClassPropertyNode $node): bool`
`60`	`60`	`{`
	`61`	`+ if ($node->isReadOnly() \|\| $node->isReadOnlyByPhpDoc()) {`
	`62`	`+ return true;`
	`63`	`+ }`
	`64`	`+`
`61`	`65`	`if ($node->isPrivateSet()) {`
`62`	`66`	`return true;`
`63`	`67`	`}`