Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deploy-tiproxy: Fix config section for session tokens #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

deploy-tiproxy: Fix config section for session tokens #2947

wants to merge 2 commits into from
+4 −3

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 6, 2025

First-time contributors' checklist

What is changed, added, or deleted? (Required)

The session token variables are not in the global part of the config, but in the security section.

mysql-8.0.11-TiDB-v8.5.2> SHOW CONFIG WHERE Type='tidb' AND NAME LIKE 'security.session-token-signing-%';
+------+----------------------------------------------------+-------------------------------------+------------------------------------+
| Type | Instance                                           | Name                                | Value                              |
+------+----------------------------------------------------+-------------------------------------+------------------------------------+
| tidb | basic-tidb-0.basic-tidb-peer.tidb-cluster.svc:4000 | security.session-token-signing-cert | /etc/tiproxy-session-token/tls.crt |
| tidb | basic-tidb-0.basic-tidb-peer.tidb-cluster.svc:4000 | security.session-token-signing-key  | /etc/tiproxy-session-token/tls.key |
| tidb | basic-tidb-1.basic-tidb-peer.tidb-cluster.svc:4000 | security.session-token-signing-cert | /etc/tiproxy-session-token/tls.crt |
| tidb | basic-tidb-1.basic-tidb-peer.tidb-cluster.svc:4000 | security.session-token-signing-key  | /etc/tiproxy-session-token/tls.key |
+------+----------------------------------------------------+-------------------------------------+------------------------------------+
4 rows in set (0.082 sec)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version for v1.x)
  • feature/v2 (the latest development version for v2.x)
  • v2.0 (TiDB Operator 2.0 versions)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@dveeden dveeden requested review from djshow832 and hfxsd October 6, 2025 22:48
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Oct 6, 2025

I changed the links that now get a 404 (and then a redirect).

I changed them to point to "stable". The other option is to use point them to docs-archive instead of docs if they must point to v7.6.

@djshow832 is stable ok for this?

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2025

@djshow832: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 djshow832 approved these changes

@hfxsd hfxsd Awaiting requested review from hfxsd

Assignees

No one assigned

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dveeden @djshow832