Completely rewrite news.py and unit tests
#203
Conversation
Rewrite the news module because the underlying news API has been dead for years. The rewritten news.py scrapes the Pittwire website for official Pitt news articles. The rewritten unit tests for news.py mocks API requests and achieves 100% code coverage with pytest.
| ) | ||
| PITT_BASE_URL = "https://www.pitt.edu" | ||
|
|
||
| Category = Literal["features-articles", "accolades-honors", "ones-to-watch", "announcements-and-updates"] |
There was a problem hiding this comment.
Why are the categories and topics hard-coded? These will probably change over time right?
There was a problem hiding this comment.
Yeah, Pittwire might add/remove topics over time (though I suspect that the categories are much less likely to change). We could scrape the lists of categories and topics so that they don't need to be hard-coded, but that'll break if the website layout changes too drastically. If you feel like that's a better alternative, we can do that in a separate PR. Otherwise, we'll just need to keep an eye on the Pittwire website occasionally to make sure that the lists are up-to-date.
There was a problem hiding this comment.
We should scrape it. We have no idea what the maintenance of this repo will look like over time. It's certainly had its lulls over time, so let's make it withstand the lack of us
Fixes #128, fixes #166
Rewrite the
newsmodule because the underlying news API has been dead for years. The rewrittennews.pyscrapes the Pittwire website for official Pitt news articles. The rewritten unit tests fornews.pymocks API requests and achieves 100% code coverage withpytest.