deps/reftable: drop Git-specific QSORT macro in the writer code

pks-t · pks-t · commit b7eaf6f51854 · 2025-08-05T11:34:28.000+02:00
The reftable writer accidentally uses the Git-specific `QSORT()` macro.
This macro removes the need for the caller to provide the element size,
but other than that it's mostly equivalent to `qsort()`.

Replace the macro accordingly. This incompatibility is a bug in Git that
needs to be fixed upstream.
diff --git a/deps/reftable/writer.c b/deps/reftable/writer.c
@@ -399,7 +399,10 @@ int reftable_writer_add_refs(struct reftable_writer *w,
 {
 	int err = 0;
 	int i = 0;
-	QSORT(refs, n, reftable_ref_record_compare_name);
+
+	if (n > 1)
+		qsort(refs, n, sizeof(*refs), reftable_ref_record_compare_name);
+
 	for (i = 0; err == 0 && i < n; i++) {
 		err = reftable_writer_add_ref(w, &refs[i]);
 	}
@@ -490,7 +493,9 @@ int reftable_writer_add_logs(struct reftable_writer *w,
 {
 	int err = 0;
 	int i = 0;
-	QSORT(logs, n, reftable_log_record_compare_key);
+
+	if (n > 1)
+		qsort(logs, n, sizeof(*logs), reftable_log_record_compare_key);
 
 	for (i = 0; err == 0 && i < n; i++) {
 		err = reftable_writer_add_log(w, &logs[i]);
