Thanks to visit codestin.com
Credit goes to github.com

Skip to content

1197 support non-static dependencies #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xael-fry merged 2 commits into from
Aug 24, 2018
Merged

1197 support non-static dependencies #1198

xael-fry merged 2 commits into from
Aug 24, 2018

Conversation

@asolntsev
Copy link
Contributor

@asolntsev asolntsev commented Oct 16, 2017 •
edited
Loading

in

  • jobs
  • plugins (after reloading plugins)
  • controllers
  • CookieSessionStore

@asolntsev asolntsev self-assigned this Oct 16, 2017
@asolntsev asolntsev requested a review from xael-fry October 16, 2017 06:48
@asolntsev asolntsev mentioned this pull request Oct 16, 2017
Merged
xael-fry
xael-fry previously requested changes Oct 17, 2017
View reviewed changes
Copy link
Member

@xael-fry xael-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you merged #2138 please add documentation for the new annotation.
Please add documentation and tests for this feature

@asolntsev
Copy link
Contributor Author

asolntsev commented Oct 17, 2017

@xael-fry Sure, I will add documentation and tests.

@asolntsev
Copy link
Contributor Author

asolntsev commented Oct 18, 2017

@xael-fry I have made the requested changes. Can you review again?

P.S. What did you mean in "As you merged #2138"? What does this number mean? And what documentation should I add?

@asolntsev asolntsev dismissed xael-fry’s stale review October 19, 2017 10:55

done (except documentation for #2138)

@asolntsev asolntsev force-pushed the use-dependency-injection branch from 3b3bc96 to 3404448 Compare October 19, 2017 21:02
@asolntsev
1197 support non-static dependencies
fcabd0a 
in
* jobs
* plugins (after reloading plugins)
* controllers
* CookieSessionStore
@asolntsev asolntsev force-pushed the use-dependency-injection branch from 3404448 to fcabd0a Compare October 22, 2017 14:17
@xael-fry xael-fry added this to the 1.5.2 milestone Aug 24, 2018
@xael-fry xael-fry merged commit 3048384 into playframework:master Aug 24, 2018
@xael-fry
Copy link
Member

xael-fry commented Aug 24, 2018 •
edited
Loading

Merged
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xael-fry xael-fry xael-fry approved these changes

Assignees

@asolntsev asolntsev

Labels

None yet

Projects

None yet

Milestone

1.5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@asolntsev @xael-fry